[kube_state] add kubernetes_state.nodes.by_condition count #1277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a count metric
kubernetes_state.nodes.by_condition
extracted from thekube_node_status_condition
ksm metric.Current known tag values:
Aggregation is done client-side, and we report zeroes for all statuses to avoid non-data graphing issues. That makes for 12 new timeseries per cluster. Node-specific state is visible via the existing service checks.
Motivation
Although the
kubernetes_state.node.*
service check allow to set alerts, we cannot graph them. This count could allow a user to graph their ready node count alongside their autoscaling group size for example. This count would not superseede the existing SCs, that offer node granularity.Having node granularity on these counts would bring the
no data
issues we have withkubernetes_state.pod.ready
when churning.Versioning
manifest.json
datadog_checks/{integration}/__init__.py
CHANGELOG.md
. Please useUnreleased
as the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?