Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add preemption victims metric as histogram #12659

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

arapulido
Copy link
Contributor

@arapulido arapulido commented Aug 2, 2022

What does this PR do?

Re-adds pod_preemption_victims metric as a histogram

Motivation

The pod_preemption_victims metric had a couple of changes over time that were not reflected in the integration.

First, in 1.17, it was moved from a Gauge to a Histogram.

Then, in 1.19 it changed its name to preemption_victims.

These changes were not reflected in the integration, and the metric was lost.

This PR readds that metrics back (with the new name, as a histogram).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #12659 (c3fcd31) into master (dea6c14) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
kube_scheduler 97.05% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@arapulido arapulido marked this pull request as ready for review August 2, 2022 15:24
@arapulido arapulido requested review from a team as code owners August 2, 2022 15:24
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/DataDog/integrations-core/blob/master/kube_scheduler/metadata.csv should be updated accordingly, kube_scheduler.pod_preemption.victims is marked as gauge.

@arapulido arapulido force-pushed the ara.pulido/preemption_victims_fix branch from 4d18b22 to 6dfc0a8 Compare August 3, 2022 07:37
@arapulido
Copy link
Contributor Author

@ahmed-mez done

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@arapulido arapulido force-pushed the ara.pulido/preemption_victims_fix branch from 6dfc0a8 to 8d5c633 Compare August 3, 2022 07:42
@arapulido arapulido force-pushed the ara.pulido/preemption_victims_fix branch from 8d5c633 to c3fcd31 Compare August 3, 2022 07:43
@arapulido arapulido requested a review from ahmed-mez August 3, 2022 08:16
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arapulido arapulido merged commit 5c57a8c into master Aug 3, 2022
@arapulido arapulido deleted the ara.pulido/preemption_victims_fix branch August 3, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants