-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add preemption victims metric as histogram #12659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think https://github.com/DataDog/integrations-core/blob/master/kube_scheduler/metadata.csv should be updated accordingly, kube_scheduler.pod_preemption.victims
is marked as gauge
.
4d18b22
to
6dfc0a8
Compare
@ahmed-mez done |
The |
6dfc0a8
to
8d5c633
Compare
8d5c633
to
c3fcd31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Re-adds
pod_preemption_victims
metric as a histogramMotivation
The
pod_preemption_victims
metric had a couple of changes over time that were not reflected in the integration.First, in 1.17, it was moved from a Gauge to a Histogram.
Then, in 1.19 it changed its name to
preemption_victims
.These changes were not reflected in the integration, and the metric was lost.
This PR readds that metrics back (with the new name, as a histogram).
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached