Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add missing metric: pod_preemption.attempts #12656

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

arapulido
Copy link
Contributor

What does this PR do?

It changes the metric called scheduler_total_preemption_attempts to scheduler_preemption_attempts_total, from 1.19.

Motivation

This metric changed its name in 1.19 and the integration was never changed, so the metric pod_preemption.attempts was missing in newer versions of Kubernetes

Details in the K8s changelog: https://www-1.muraena.okta-security-dev.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#other-cleanup-or-flake-7

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@arapulido arapulido marked this pull request as ready for review August 2, 2022 13:19
@arapulido arapulido requested review from a team as code owners August 2, 2022 13:19
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #12656 (f6cc73a) into master (39aa394) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
kube_scheduler 97.02% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@arapulido arapulido merged commit dea6c14 into master Aug 3, 2022
@arapulido arapulido deleted the ara.pulido/change_preemtion_metric_name branch August 3, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants