Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add missing metric: rest_client_request_duration_seconds #12636

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

arapulido
Copy link
Contributor

@arapulido arapulido commented Jul 29, 2022

What does this PR do?

The metric called rest_client_request_latency_seconds changed its name to rest_client_request_duration_seconds but that was never changed in our integration, so the metric client.http.requests_duration is missing

https://github.com/kubernetes/kubernetes/blob/8ac5d4d6a92d59bba70844fbd6e5de2383a08c96/CHANGELOG/CHANGELOG-1.14.md#deprecated-metrics

Motivation

I am working on updating the Kube Scheduler OOTB dashboard, but I realized that the current one had the HTTP duration histogram widget empty:

https://a.cl.ly/mXuxXrDg

This is because the corresponding metric is not there.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #12636 (b638e35) into master (a221d6b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
kube_scheduler 97.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@arapulido arapulido changed the title new name for metric rest_client_request_duration_seconds Re-add missing metric: rest_client_request_duration_seconds Aug 1, 2022
@arapulido arapulido marked this pull request as ready for review August 1, 2022 07:45
@arapulido arapulido requested review from a team as code owners August 1, 2022 07:45
@arapulido arapulido merged commit 43ed4be into master Aug 1, 2022
@arapulido arapulido deleted the arapulido-patch-1 branch August 1, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants