Prevent from publishing datadog-checks-downloader to PyPI #12556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedricvanrompay-datadog
approved these changes
Jul 21, 2022
yzhan289
reviewed
Jul 22, 2022
| @@ -19,6 +19,7 @@ authors = [ | |||
| { name = "Datadog", email = "packages@datadoghq.com" }, | |||
| ] | |||
| classifiers = [ | |||
| "Private :: Do Not Upload", | |||
There was a problem hiding this comment.
This is a good idea, although maybe we should also do this for all of the integrations excluding the base check and datadog-checks-dev, since we don't want them on PyPI either. Could you add this to the templates as well? (here's an example template). Maybe we can also have a script to retroactively apply this classifier to existing checks. @ofek thoughts?
FlorentClarret
approved these changes
Aug 2, 2022
ofek
approved these changes
Aug 2, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a classifier that makes sure the download-checks-downloader is not published on PyPI.