Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new scheduling metrics available in k8s v1.23+ #12111

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Add new scheduling metrics available in k8s v1.23+ #12111

merged 3 commits into from
Jun 7, 2022

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Collect the following metrics

  • kube_scheduler.scheduling.pod.scheduling_attempts
  • kube_scheduler.scheduling.pod.scheduling_duration
  • kube_scheduler.scheduling.attempt_duration

Motivation

Keep the integration up-to-date

Additional Notes

Requires k8s v1.23+ for QA

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners May 31, 2022 13:15
@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #12111 (5991743) into master (0ffe4ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
kube_scheduler 96.98% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

L3n41c
L3n41c reviewed Jun 3, 2022
View reviewed changes
kube_scheduler/metadata.csv Outdated Show resolved Hide resolved
@ahmed-mez @L3n41c
add unit
5991743 
Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com>
@ahmed-mez ahmed-mez requested a review from L3n41c June 3, 2022 08:29
@ahmed-mez ahmed-mez merged commit b4ee036 into master Jun 7, 2022
@ahmed-mez ahmed-mez deleted the ahmed/scheduler-1.23 branch June 7, 2022 08:11
github-actions bot pushed a commit that referenced this pull request Jun 7, 2022
@ahmed-mez
Add new scheduling metrics available in k8s v1.23+ (#12111) b4ee036
0ef97a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3n41c L3n41c L3n41c approved these changes

Assignees
No one assigned
Labels
integration/kube_scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmed-mez @L3n41c