Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic bearer tokens (Bound Service Account Token Volume) #11915

Merged
merged 2 commits into from
May 10, 2022
Merged

Support dynamic bearer tokens (Bound Service Account Token Volume) #11915

merged 2 commits into from
May 10, 2022

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Support refreshing the service account's auth token needed for Bound Service Account Token Volume (k8s v1.22+)

Motivation

fixes DataDog/datadog-agent#10604

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners May 2, 2022 14:30
@github-actions
Copy link

github-actions bot commented May 2, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ahmed-mez ahmed-mez requested a review from a team as a code owner May 2, 2022 14:35
@github-actions
Copy link

github-actions bot commented May 3, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ahmed-mez ahmed-mez removed the request for review from a team May 4, 2022 09:33
@github-actions
Copy link

github-actions bot commented May 4, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented May 5, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

clamoriniere
clamoriniere previously approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the bearer token refresh logic

yzhan289
yzhan289 previously approved these changes May 5, 2022
View reviewed changes
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ahmed-mez ahmed-mez requested a review from yzhan289 May 10, 2022 10:14
@hithwen hithwen merged commit e396c46 into master May 10, 2022
@hithwen hithwen deleted the ahmed/bound-sa branch May 10, 2022 10:54
github-actions bot pushed a commit that referenced this pull request May 10, 2022
@hithwen
Support dynamic bearer tokens (Bound Service Account Token Volume) (#…
34025b8 
…11915)

* Support dynamic bearer tokens (Bound Service Account Token Volume) e396c46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche left review comments

@hithwen hithwen hithwen approved these changes

@clamoriniere clamoriniere clamoriniere approved these changes

@cswatt cswatt cswatt left review comments

@yzhan289 yzhan289 Awaiting requested review from yzhan289

Assignees
No one assigned
Labels
dev/tooling integration/azure_iot_edge integration/cilium integration/cockroachdb integration/coredns integration/crio integration/datadog_checks_base integration/datadog_checks_dev integration/datadog_cluster_agent integration/etcd integration/external_dns integration/gitlab_runner integration/gitlab integration/haproxy integration/ibm_ace integration/istio integration/kube_apiserver_metrics integration/kube_controller_manager integration/kube_dns integration/kube_metrics_server integration/kube_proxy integration/kube_scheduler integration/kubelet integration/kubernetes_state integration/linkerd integration/nginx_ingress_controller integration/openmetrics integration/openstack_controller integration/openstack integration/scylla integration/snowflake integration/tokumx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes api server metrics: reload bearer token to avoid failing on stale token
6 participants
@ahmed-mez @djmitche @clamoriniere @hithwen @cswatt @yzhan289