Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new metric on backends count and status for proxysql #11812

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

aymeric-ledizes
Copy link
Contributor

What does this PR do?

This PR add a new additional metric to know the numbers of mysql backends and their status (as tags of the metric)

Motivation

Currently there is a service check on backend status but no metrics.
The service check does not meet our needs as it does not allow to customize queries (ex: no custom time range evaluation)

Additional Notes

Despite there is already a service check proxysql.backend.status. This PR seems the only way to correctly monitor and alert on mysql backends count/status

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@aymeric-ledizes aymeric-ledizes force-pushed the proxysql_backend_count branch 2 times, most recently from 5af0a78 to f8ecd79 Compare April 11, 2022 16:00
@aymeric-ledizes aymeric-ledizes force-pushed the proxysql_backend_count branch from f8ecd79 to 6446915 Compare April 11, 2022 16:26
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #11812 (6446915) into master (70701cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
proxysql 98.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aymeric-ledizes aymeric-ledizes marked this pull request as ready for review April 11, 2022 16:37
@aymeric-ledizes aymeric-ledizes requested review from a team as code owners April 11, 2022 16:37
@aymeric-ledizes
Copy link
Contributor Author

Thanks for the approve @maycmlee 🙏 Can we merge this PR?

@maycmlee
Copy link
Contributor

Hi @aymeric-ledizes! Thanks for contributing. This is waiting on an engineering review before it can be merged.

@hithwen hithwen merged commit 05bd493 into DataDog:master Apr 27, 2022
@yzhan289 yzhan289 changed the title add a new metric on backends count and status for proxysql Add a new metric on backends count and status for proxysql May 24, 2022
@yzhan289 yzhan289 mentioned this pull request May 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants