Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gssapi as a dependency #11725

Merged
merged 19 commits into from
Mar 31, 2022
Merged

Add gssapi as a dependency #11725

merged 19 commits into from
Mar 31, 2022

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Mar 23, 2022 •
edited
Loading

What does this PR do?

Adds gssapi as a dependency

Motivation

In the kafka consumer check, we give users the option to use GSSAPI authentication when connecting. In the kafka python library, gssapi is not a direct dependency, and if it is not installed, the library errors when attempting to use it. We are shipping the library so authentication with gssapi can be supported by default without installing an extra dependency.

Additional Notes

NOTE: gssapi does not support python 2 anymore, so we must use an older version of the library for python 2 installs

Additionally, gssapi requires gcc to be installed

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #11725 (bc4c56d) into master (7dd8265) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
calico 83.33% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_cluster_agent 90.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ghost ghost added the dev/testing label Mar 24, 2022
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@sarah-witt
Copy link
Contributor Author

/azp run PR Changes

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@sarah-witt sarah-witt changed the title Add gssapi dep Add gssapi as a dependency Mar 30, 2022
@sarah-witt sarah-witt marked this pull request as ready for review March 31, 2022 14:23
@sarah-witt sarah-witt requested review from a team as code owners March 31, 2022 14:23
ofek
ofek requested changes Mar 31, 2022
View reviewed changes
kafka_consumer/tox.ini Outdated
@@ -21,7 +21,7 @@ passenv =
COMPOSE*
extras = deps
deps =
-e../datadog_checks_base[deps]
-e../datadog_checks_base[deps,http]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, fixed!

djmitche
djmitche approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 datadog_checks_base/datadog_checks/base/data/agent_requirements.in

@sarah-witt sarah-witt merged commit f3c4875 into master Mar 31, 2022
@sarah-witt sarah-witt deleted the sarah/add-gssapi-dep branch March 31, 2022 18:37
github-actions bot pushed a commit that referenced this pull request Mar 31, 2022
@sarah-witt
Add gssapi as a dependency (#11725)
4d67975 
* Add gssapi dep

* Fix quote

* Add install script

* add metadata

* move to linux dir

* rename and http

* Remove install commands

* Update permissions

* catch exception and add comment

* Change message

* Update match

* Add license

* install gcc

* add start command

* Dont install

* Revert "Dont install"

This reverts commit c786e42.

* remove f3c4875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@djmitche djmitche djmitche approved these changes

Assignees
No one assigned
Labels
dependencies dev/testing dev/tooling integration/datadog_checks_base integration/datadog_checks_dev integration/kafka_consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @djmitche @ofek