Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric_patterns to base template #11696

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Add metric_patterns to base template #11696

merged 1 commit into from
Mar 18, 2022

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds metric_patterns to the base template

Motivation

#11508

Additional Notes

Will fail validation until #11695 is merged

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt mentioned this pull request Mar 17, 2022
Merged
4 tasks
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #11696 (8a7a7e3) into master (1860e24) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review March 17, 2022 18:31
@sarah-witt sarah-witt requested a review from a team as a code owner March 17, 2022 18:31
@sarah-witt sarah-witt merged commit 1314a92 into master Mar 18, 2022
@sarah-witt sarah-witt deleted the sarah/ddev-add-metrics-pattern-template branch March 18, 2022 18:34
fanny-jiang pushed a commit that referenced this pull request Mar 18, 2022
@sarah-witt @fanny-jiang
Add metric_patterns to template and fix tests (#11696)
4afbd55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarah-witt @ofek @fanny-jiang