Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check options from jmx template #11686

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Mar 16, 2022

What does this PR do?

  • Removes default check options from jmx template
  • Creates a template all_integrations for both jmx and check integrations
  • Makes the default template only applicable for check integrations

Motivation

jmx integrations are not checks and cannot use all of the options in the default template, we need a template that is only applicable to python checks.

Additional Notes

Another approach is renaming template/default to template/default_check instead

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt reopened this Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #11686 (b762608) into master (fa8d70c) will decrease coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.20% <ø> (ø)
hazelcast 92.39% <ø> (ø)
sonarqube 95.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@sarah-witt sarah-witt marked this pull request as ready for review March 16, 2022 20:44
@sarah-witt sarah-witt requested a review from a team as a code owner March 16, 2022 20:44
@sarah-witt sarah-witt changed the title Remove default template from jmx template Create default template for checks, remove previous default template from jmx template Mar 16, 2022
@sarah-witt sarah-witt changed the title Create default template for checks, remove previous default template from jmx template Remove default check options from jmx template Mar 16, 2022
@sarah-witt sarah-witt changed the title Remove default check options from jmx template Remove check options from jmx template Mar 16, 2022
@sarah-witt sarah-witt merged commit 9bcf7cb into master Mar 17, 2022
@sarah-witt sarah-witt deleted the sarah/jmx-config-spec-fix branch March 17, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment