Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file #11428

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Add pyproject.toml file #11428

merged 2 commits into from
Feb 17, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 7, 2022

Motivation

Modernize packaging, continues #11233

Additional Notes

The setup.py file will be removed when we drop Python 2 since new-style editable installations require versions of pip that are Python 3-only

Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #11469 to be merged

yzhan289
yzhan289 previously approved these changes Feb 16, 2022
@yzhan289
Copy link
Contributor

Need to resolve conflicts, should rebase from master

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

sap_hana/pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Andrew Zhang <andrew.zhang@datadoghq.com>
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #11428 (5bf6885) into master (f11d94f) will decrease coverage by 0.03%.
The diff coverage is n/a.

Flag Coverage Δ
amazon_msk 88.83% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
openmetrics 97.14% <ø> (ø)
sap_hana 91.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt merged commit 2e894f4 into master Feb 17, 2022
@sarah-witt sarah-witt deleted the ofek/pyproject_sap_hana branch February 17, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants