Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file #11385

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add pyproject.toml file #11385

merged 1 commit into from
Feb 18, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 7, 2022

Motivation

Modernize packaging, continues #11233

Additional Notes

The setup.py file will be removed when we drop Python 2 since new-style editable installations require versions of pip that are Python 3-only

Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you can add the kubernetes keyword otherwise /lgtm

"datadog",
"datadog agent",
"datadog check",
"kube_scheduler",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"kube_scheduler",
"kube_scheduler",
"kubernetes",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These in fact do nothing because we don't upload to PyPI (which uses them for search)

@ofek ofek merged commit 54de99d into master Feb 18, 2022
@ofek ofek deleted the ofek/pyproject_kube_scheduler branch February 18, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants