[openstack] Send external host tags to Agent6 #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
commented
Feb 16, 2018
| # Agent >= 6.0: the check pushes tags invoking `set_external_tags` | ||
| from datadog_agent import set_external_tags | ||
| except ImportError: | ||
| # Agent < 6.0: the Agent pulls tags invoking `VSphereCheck.get_external_host_tags` |
There was a problem hiding this comment.
s/VSphereCheck/OpenStackCheck/
truthbk
previously approved these changes
Feb 16, 2018
ofek
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Call
set_external_tagswhen the check runs in Agent >= v6.0Motivation
Check was only partially working in Agent >= v6.0
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?