Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize key and token options behaviour #11214

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Standardize key and token options behaviour #11214

merged 4 commits into from
Jan 26, 2022

Conversation

coignetp
Copy link
Contributor

What does this PR do?

read_token now return the token value, so it has a similar behaviour as read_key.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner January 26, 2022 09:28
@coignetp coignetp changed the title Update read_token return value Standardize key and token options behaviour Jan 26, 2022
hithwen
hithwen reviewed Jan 26, 2022
View reviewed changes
snowflake/datadog_checks/snowflake/check.py Outdated
Comment on lines 55 to 56
if self._config.private_key_password:
self.register_secret(self._config.private_key_password)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can split

@coignetp coignetp merged commit c733632 into master Jan 26, 2022
@coignetp coignetp deleted the paul/sf-read-token branch January 26, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coignetp @hithwen