Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check intermediate certificate protocol version #11207

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Check intermediate certificate protocol version #11207

merged 2 commits into from
Jan 27, 2022

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jan 25, 2022 •
edited
Loading

What does this PR do?

Check for protocol version when fetching intermediate certificate

Motivation

Additional Notes

Not failing so it's not a breaking change for customer

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/tls label Jan 25, 2022
@coignetp coignetp force-pushed the paul/tls-intermediate branch from 766aaa3 to a11d3e7 Compare January 25, 2022 12:57
@coignetp coignetp marked this pull request as ready for review January 26, 2022 10:52
@coignetp coignetp requested a review from a team as a code owner January 26, 2022 10:52
@coignetp coignetp merged commit 080fd61 into master Jan 27, 2022
@coignetp coignetp deleted the paul/tls-intermediate branch January 27, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
integration/tls
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coignetp @hithwen