-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload bearer token from disk to work with kubernetes bound-service-a… #11176
Conversation
0da3a04
to
dcd2a22
Compare
dcd2a22
to
8f88bfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why agent-core owns datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
but that seems to now use different config options and have some other refactoring unrelated to this PR?
the change is to always set execute |
8f88bfd
to
0071d68
Compare
added 3 more places that needed to be patched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks -- mixins.py looks good
was still missing:
so resorting to manually doing what the token controller does + longer expiration:
and volumeMounts
and volumes
|
…ccount-tokens
What does this PR do?
fixes DataDog/datadog-agent#10604
... still need to confirm this works
... also needs to be an opt-in flag since this check could be used for anything
Motivation
the token on disk is expired every 1h by kubernetes so we need to reload it
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached