-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade psutil to 5.9.0 #11139
Upgrade psutil to 5.9.0 #11139
Conversation
Windows E2E tests are failing with
which seems like a CI issue? |
|
I can reproduce if I try to do The error does not happen if I try to install version 5.8.0, and after doing that it seems like I can upgrade to 5.9.0 seamlessly, even if I do |
I am also able to reproduce it when installing on the embedded Python 2 environment of the Agent from DataDog/datadog-agent#10544 (i.e. using this msi) with the same behavior, so the custom patches are not the issue. I can't reproduce with a fresh install of Python 2 when doing C:\Python27\python.exe -m pip install psutil==5.7.2
C:\Python27\python.exe -m pip install psutil==5.9.0 |
3baa9e5
to
7a5e7a6
Compare
`rg 'psutil==' -l | xargs sd 'psutil==5.7.2' 'psutil==5.9.0'`
7a5e7a6
to
bcad082
Compare
I have restored this branch to its original setup and moved testing to #11196. To summarize: the end to end test failure is a limitation of the end to end testing environment, where the dependencies are updated while the Agent is running, and therefore holding some files. |
What does this PR do?
Upgrade
psutil
to 5.9.0. Validate builds are failing because of the need for DataDog/datadog-agent#10544.Motivation
Include giampaolo/psutil#1961 fix
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached