Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows support to IBM MQ #10737

Merged
merged 49 commits into from
Dec 23, 2021
Merged

Add Windows support to IBM MQ #10737

merged 49 commits into from
Dec 23, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Nov 26, 2021 •
edited
Loading

@hithwen hithwen requested review from a team as code owners November 26, 2021 09:40
@hithwen hithwen requested a review from a team as a code owner November 26, 2021 09:42
djmitche
djmitche previously approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements.in change looks good -- I didn't look at the rest.

@albertvaka
Copy link
Contributor

The client is installed in c:\ibm_mq in the builder. I assume you need to specify this somewhere in the code, since that's a path I chose and not a standard one.

@hithwen hithwen force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch from f16c9ab to dcbcdfe Compare December 13, 2021 10:32
@ghost ghost added the documentation label Dec 16, 2021
@ghost ghost added the dev/testing label Dec 16, 2021
@ofek ofek force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch 2 times, most recently from b5e9e79 to be09296 Compare December 21, 2021 02:37
@ofek ofek force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch from be09296 to 7918306 Compare December 21, 2021 02:47
@hithwen
migrate script to python
4b9a70f
@hithwen
t merge origin/master
885cedf 
Merge branch 'js/FRAGENT-1564-ibm-mq-on-windows' of github.com:DataDog/integrations-core into js/FRAGENT-1564-ibm-mq-on-windows
@hithwen hithwen force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch from 71c3e29 to 885cedf Compare December 21, 2021 10:03
@hithwen hithwen force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch from 05d8c0d to 52fe7f3 Compare December 21, 2021 16:02
@hithwen hithwen force-pushed the js/FRAGENT-1564-ibm-mq-on-windows branch from 52fe7f3 to e1f2462 Compare December 21, 2021 16:10
hithwen
hithwen commented Dec 22, 2021
View reviewed changes
ibm_mq/tests/common.py Outdated
Comment on lines 23 to 24
if RUNNING_ON_WINDOWS_CI:
import pymqi # noqa: F401
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered in the unit tests that are running on windows CI

Copy link
Contributor Author

@hithwen hithwen Dec 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/DataDog/integrations-core/blob/master/ibm_mq/tests/test_ibm_mq_unit.py#L15

https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=84586&view=logs&j=9720347a-34cb-5824-38aa-606c39f81a9d&t=11fc3946-6cf4-5dcd-eba8-870db31cbc9b&l=53

@DataDog DataDog deleted a comment from github-actions bot Dec 22, 2021
@DataDog DataDog deleted a comment from codecov bot Dec 22, 2021
@DataDog DataDog deleted a comment from github-actions bot Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021 •
edited
Loading

Codecov Report

Merging #10737 (e5bb452) into master (a38cfb5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
ibm_mq 89.67% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

coignetp
coignetp approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@hithwen hithwen merged commit 709a9d0 into master Dec 23, 2021
@hithwen hithwen deleted the js/FRAGENT-1564-ibm-mq-on-windows branch December 23, 2021 11:25
@ofek ofek changed the title Add windows support Add Windows support to IBM MQ Dec 23, 2021
cswatt pushed a commit that referenced this pull request Jan 5, 2022
@hithwen @ofek @cswatt
Add windows support (#10737)
4d71133 
* Add support for windows

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@djmitche djmitche djmitche left review comments

Assignees
No one assigned
Labels
dependencies dev/testing documentation integration/datadog_checks_base integration/ibm_mq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hithwen @albertvaka @djmitche @coignetp @ofek