Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new include_labels option #10617

Merged
merged 8 commits into from
Nov 13, 2021
Merged

Document new include_labels option #10617

merged 8 commits into from
Nov 13, 2021

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Document new include_labels openmetrics option.

Motivation

Additional Notes

Also bumps the minimum base package in each check that uses the new option.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #10617 (3546e6f) into master (dece89d) will increase coverage by 0.02%.
The diff coverage is n/a.

Flag Coverage Δ
amazon_msk 88.83% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
azure_iot_edge 81.93% <ø> (ø)
cilium 85.84% <ø> (+1.88%) ⬆️
cockroachdb 97.18% <ø> (ø)
coredns 95.74% <ø> (ø)
crio 100.00% <ø> (ø)
datadog_checks_dev 79.76% <ø> (ø)
datadog_cluster_agent 97.50% <ø> (ø)
etcd 93.27% <ø> (ø)
external_dns 100.00% <ø> (ø)
gitlab 89.94% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
haproxy 95.08% <ø> (+0.16%) ⬆️
istio 76.87% <ø> (+0.57%) ⬆️
kong 92.21% <ø> (ø)
kube_apiserver_metrics 97.35% <ø> (ø)
kube_scheduler 96.20% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
nginx_ingress_controller 98.30% <ø> (ø)
openmetrics 97.14% <ø> (ø)
scylla 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

sarah-witt
sarah-witt previously approved these changes Nov 12, 2021
cswatt
cswatt previously approved these changes Nov 12, 2021
@fanny-jiang fanny-jiang dismissed stale reviews from cswatt and sarah-witt via 331beee November 12, 2021 22:26
@fanny-jiang fanny-jiang requested a review from a team as a code owner November 12, 2021 22:26
@fanny-jiang
Copy link
Contributor Author

/azp run PR All

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

sarah-witt
sarah-witt previously approved these changes Nov 12, 2021
@fanny-jiang fanny-jiang merged commit 0a433cb into master Nov 13, 2021
@fanny-jiang fanny-jiang deleted the fanny/om-incl-labels branch November 13, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment