Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network checks] Kill skip_event option #1054

Merged
merged 3 commits into from
Mar 17, 2018
Merged

[network checks] Kill skip_event option #1054

merged 3 commits into from
Mar 17, 2018

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Jan 25, 2018 •
edited
Loading

What does this PR do?

Kill skip_event option in network checks
Fixes DataDog/dd-agent#1128

Motivation

What inspired you to submit this pull request?

Testing Guidelines

Tests should pass once the sister PR DataDog/dd-agent#3643 is merged.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@zippolyte zippolyte added this to the 5.22 milestone Jan 25, 2018
@hush-hush hush-hush modified the milestones: 5.22, 5.23 Feb 7, 2018
masci
masci approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@zippolyte zippolyte merged commit bbe194d into master Mar 17, 2018
@masci masci modified the milestones: 6.1, 6.1/5.23 Mar 21, 2018
@masci masci deleted the hippo/skip_event branch May 3, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@zippolyte @masci @hush-hush