Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base package requirements #10390

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Bump base package requirements #10390

merged 1 commit into from
Oct 12, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Tests are failing due to server tag still being generic in previous versions of datadog_base_checks #10344

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #10390 (51f0b11) into master (0e2b9b8) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
avi_vantage 91.92% <ø> (ø)
clickhouse 96.65% <ø> (ø)
ibm_was 97.45% <ø> (ø)
sap_hana 91.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt merged commit 7ac0e31 into master Oct 12, 2021
@sarah-witt sarah-witt deleted the paul/fix-base branch October 12, 2021 15:25
sarah-witt pushed a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants