Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement disable generic tags for sqlserver #10290

Merged
merged 9 commits into from
Oct 1, 2021
Merged

implement disable generic tags for sqlserver #10290

merged 9 commits into from
Oct 1, 2021

Conversation

HantingZhang2
Copy link
Contributor

What does this PR do?

implement disable generic tags for sqlserver

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@HantingZhang2 HantingZhang2 requested review from a team as code owners September 30, 2021 14:29
@codecov
Copy link

codecov bot commented Sep 30, 2021 •
edited
Loading

Codecov Report

Merging #10290 (3cbec6f) into master (83fd48d) will increase coverage by 0.30%.
The diff coverage is 71.42%.

Flag Coverage Δ
sqlserver 82.29% <71.42%> (+15.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ruthnaebeck
ruthnaebeck suggested changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

sqlserver/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
@HantingZhang2 @ruthnaebeck
Update sqlserver/assets/configuration/spec.yaml
8383e24 
Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@HantingZhang2
change desc
328522a
@HantingZhang2
Merge branch 'hz-add-disable-generic-tags-sqlserver' of github.com:Da…
a06b7c6 
…taDog/integrations-core into hz-add-disable-generic-tags-sqlserver
coignetp
coignetp requested changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to bump sqlserver base minimum dependency to 21.2.0

@HantingZhang2
Copy link
Contributor Author

Looks good, just need to bump sqlserver base minimum dependency to 21.2.0

Bumped

ruthnaebeck
ruthnaebeck approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@coignetp coignetp merged commit c8a934f into master Oct 1, 2021
@coignetp coignetp deleted the hz-add-disable-generic-tags-sqlserver branch October 1, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Assignees
No one assigned
Labels
documentation integration/sqlserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HantingZhang2 @ruthnaebeck @coignetp