Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clustername for invalid RFC1123 cases #10262

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix clustername for invalid RFC1123 cases #10262

merged 1 commit into from
Oct 28, 2021

Conversation

nammn
Copy link
Contributor

@nammn nammn commented Sep 29, 2021 •
edited
Loading

What does this PR do?

Builds on: DataDog/datadog-agent#9279 (more background information can be read in that respective PR)

Reading the old PRs:

I assume that the line i have changed is only used for matching the host/hostAlias with respective KSM metrics

Motivation

Builds on: DataDog/datadog-agent#9279

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #10262 (bba010e) into master (80462dd) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Flag Coverage Δ
kubernetes_state 89.52% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nammn nammn mentioned this pull request Sep 29, 2021
Merged
5 tasks
@nammn nammn marked this pull request as ready for review September 29, 2021 10:08
@nammn nammn requested review from a team as code owners September 29, 2021 10:08
@nammn nammn requested a review from a team September 29, 2021 12:54
mfpierre
mfpierre approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nammn nammn changed the title [ksm] fix clustername for invalid RFC1123 cases [DO NOT MERGE] [TO BE MERGED AFTER THE AGENT RELEASE] [ksm] fix clustername for invalid RFC1123 cases Oct 4, 2021
@sarah-witt sarah-witt changed the title [DO NOT MERGE] [TO BE MERGED AFTER THE AGENT RELEASE] [ksm] fix clustername for invalid RFC1123 cases Fix clustername for invalid RFC1123 cases Oct 28, 2021
@sarah-witt sarah-witt merged commit 14c9c7a into master Oct 28, 2021
@sarah-witt sarah-witt deleted the nnguyen/clustername branch October 28, 2021 15:38
fanny-jiang pushed a commit that referenced this pull request Nov 2, 2021
@fanny-jiang
[ksm] fix clustername for invalid RFC1123 cases (#10262)
973d1f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@mfpierre mfpierre mfpierre approved these changes

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nammn @clamoriniere @mfpierre @ChristineTChen @sarah-witt