Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for ambari #10052

Merged
merged 8 commits into from
Sep 14, 2021
Merged

Add e2e test for ambari #10052

merged 8 commits into from
Sep 14, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Sep 3, 2021

What does this PR do?

Add barebones e2e test for ambari

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested a review from a team as a code owner September 3, 2021 19:59
@ghost ghost added the integration/ambari label Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #10052 (7cdd029) into master (028f5b0) will decrease coverage by 0.00%.
The diff coverage is 53.84%.

Flag Coverage Δ
ambari 85.75% <53.84%> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yzhan289 yzhan289 requested a review from hithwen September 13, 2021 17:58
hithwen
hithwen previously approved these changes Sep 14, 2021
View reviewed changes
@yzhan289 yzhan289 merged commit 03906c4 into master Sep 14, 2021
@yzhan289 yzhan289 deleted the az/ambari-e2e branch September 14, 2021 20:42
github-actions bot pushed a commit that referenced this pull request Sep 14, 2021
@yzhan289
Add e2e test for ambari (#10052)
c726329 
* Add e2e test for ambari

* Use better instance

* Fix style

* Fix ambari

* Fix ambari style

* Clean up test

* Wrap exception

* Change to generic Exception 03906c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@hithwen hithwen hithwen left review comments

Assignees
No one assigned
Labels
integration/ambari
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzhan289 @hithwen @ofek