Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
ofek committed Nov 12, 2021
1 parent e986402 commit bcf5456
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 6 deletions.
2 changes: 2 additions & 0 deletions hazelcast/assets/configuration/spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ files:
In Transition: WARNING
- template: instances/jmx
overrides:
host.required: false
host.display_priority: 10
host.description: Hazelcast or Hazelcast Management Center server with which to connect.
port.required: false
port.display_priority: 9
port.description: Hazelcast or Hazelcast Management Center port with which to connect.
port.value.example: 1099
Expand Down
8 changes: 8 additions & 0 deletions hazelcast/datadog_checks/hazelcast/config_models/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ def instance_headers(field, value):
return get_default_field_value(field, value)


def instance_host(field, value):
return get_default_field_value(field, value)


def instance_is_jmx(field, value):
return False

Expand Down Expand Up @@ -172,6 +176,10 @@ def instance_persist_connections(field, value):
return False


def instance_port(field, value):
return 1099


def instance_process_name_regex(field, value):
return get_default_field_value(field, value)

Expand Down
4 changes: 2 additions & 2 deletions hazelcast/datadog_checks/hazelcast/config_models/instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class Config:
empty_default_hostname: Optional[bool]
extra_headers: Optional[Mapping[str, Any]]
headers: Optional[Mapping[str, Any]]
host: str
host: Optional[str]
is_jmx: Optional[bool]
java_bin_path: Optional[str]
java_options: Optional[str]
Expand All @@ -68,7 +68,7 @@ class Config:
ntlm_domain: Optional[str]
password: Optional[str]
persist_connections: Optional[bool]
port: int
port: Optional[int]
process_name_regex: Optional[str]
proxy: Optional[Proxy]
read_timeout: Optional[float]
Expand Down
9 changes: 5 additions & 4 deletions hazelcast/datadog_checks/hazelcast/data/conf.yaml.example
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,16 @@ init_config:
#
instances:

## @param host - string - required
-
## @param host - string - optional
## Hazelcast or Hazelcast Management Center server with which to connect.
#
- host: <HOST>
# host: <HOST>

## @param port - integer - required
## @param port - integer - optional - default: 1099
## Hazelcast or Hazelcast Management Center port with which to connect.
#
port: 1099
# port: 1099

## @param mc_health_check_endpoint - string - optional
## Hazelcast Management Center health check endpoint with which
Expand Down

0 comments on commit bcf5456

Please sign in to comment.