Skip to content

Commit

Permalink
Fix windows docker compose args
Browse files Browse the repository at this point in the history
  • Loading branch information
dkirov-dd committed Jan 30, 2025
1 parent 24310a5 commit ba43286
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 21 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/fips-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
matrix:
platform: [linux, windows]
agent-type: [fips-agent, standard-agent]
runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-22.04' || 'windows-2022' }}
runs-on: ${{ matrix.platform == 'linux' && 'ubuntu-22.04' || 'windows-2025' }}
name: "Test FIPS"

env:
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Set up Windows containers
if: matrix.platform == 'windows'
env:
AGENT_IMAGE: "${{ matrix.agent-type == 'fips-agent' && 'datadog/agent-dev:master-py3-win-servercore' || 'datadog/agent-dev:master-py3-win-servercore' }}"
AGENT_IMAGE: "${{ matrix.agent-type == 'fips-agent' && 'main-py3-fips-win-servercore-ltsc2022' || 'datadog/agent-dev:master-py3-win-servercore' }}"
DD_API_KEY: ${{ secrets.DD_API_KEY }}
run: |
docker compose -f .github/workflows/fips/compose/compose-windows.yml up -d
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/fips/compose/compose-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ services:
http-server-fips:
build:
context: server
dockerfile: Dockerfile
dockerfile: Dockerfile-nix
args:
BUILD_TARGET: http-server
command: ["./http-server", "ECDHE-RSA-AES128-SHA256"]
Expand All @@ -32,7 +32,7 @@ services:
http-server:
build:
context: server
dockerfile: Dockerfile
dockerfile: Dockerfile-nix
args:
BUILD_TARGET: http-server
command: ["./http-server", "ECDHE-RSA-CHACHA20-POLY1305"]
Expand Down
34 changes: 17 additions & 17 deletions .github/workflows/fips/compose/compose-windows.yml
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
services:
agent:
image: $AGENT_IMAGE
pid: host
environment:
- DD_API_KEY=$DD_API_KEY
- DD_SITE=datad0g.com
volumes:
- \\.\pipe\docker_engine:\\.\pipe\docker_engine
- "./agent/conf.d:C:/ProgramData/Datadog/conf.d"
- "./agent/checks.d:C:/ProgramData/Datadog/checks.d"
healthcheck:
test: ["CMD", "agent", "status"]
interval: 5s
timeout: 2s
retries: 3
# agent:
# image: $AGENT_IMAGE
# pid: host
# environment:
# - DD_API_KEY=$DD_API_KEY
# - DD_SITE=datad0g.com
# volumes:
# - \\.\pipe\docker_engine:\\.\pipe\docker_engine
# - "./agent/conf.d:C:/ProgramData/Datadog/conf.d"
# - "./agent/checks.d:C:/ProgramData/Datadog/checks.d"
# healthcheck:
# test: ["CMD", "agent", "status"]
# interval: 5s
# timeout: 2s
# retries: 3
http-server-fips:
build:
context: server
dockerfile: Dockerfile
dockerfile: Dockerfile-win
args:
BUILD_TARGET: http-server.exe
command: ["C:/app/http-server.exe", "ECDHE-RSA-AES128-SHA256"]
Expand All @@ -30,7 +30,7 @@ services:
http-server:
build:
context: server
dockerfile: Dockerfile
dockerfile: Dockerfile-win
args:
BUILD_TARGET: http-server.exe
command: ["C:/app/http-server.exe", "ECDHE-RSA-CHACHA20-POLY1305"]
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/fips/compose/server/Dockerfile-win
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
FROM golang:1.23

WORKDIR /app

# Copy all files
COPY . ./

ENV GO111MODULE=off

# Build the server
ARG BUILD_TARGET
RUN go build -o $env:BUILD_TARGET http-server.go

# Expose port 443
EXPOSE 443

0 comments on commit ba43286

Please sign in to comment.