Skip to content

Commit

Permalink
Remove custom tag from default test instance fixture
Browse files Browse the repository at this point in the history
  • Loading branch information
jennchenn committed Sep 8, 2023
1 parent 0b03379 commit 4b479a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion kube_scheduler/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
INSTANCE = {
'prometheus_url': 'http://localhost:10251/metrics',
'send_histograms_buckets': True,
'tags': ['custom:tag'],
}


Expand Down
4 changes: 2 additions & 2 deletions kube_scheduler/tests/test_sli_metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ def assert_metric(name, **kwargs):
# Wrapper to keep assertions < 120 chars
aggregator.assert_metric("{}.{}".format(CHECK_NAME, name), **kwargs)

assert_metric('slis.kubernetes_healthcheck', value=1, tags=['name:ping', 'type:healthz', 'custom:tag'])
assert_metric('slis.kubernetes_healthcheck', value=1, tags=['name:ping', 'type:healthz'])
assert_metric(
'slis.kubernetes_healthchecks_total',
value=2450,
tags=['name:ping', 'status:success', 'type:healthz', 'custom:tag'],
tags=['name:ping', 'status:success', 'type:healthz'],
)

aggregator.assert_all_metrics_covered()
Expand Down

0 comments on commit 4b479a2

Please sign in to comment.