Update default field name

DataDog · Nov 23, 2021 · 0ec992e · 0ec992e
1 parent 4b2bf8c
commit 0ec992e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/snowflake/datadog_checks/snowflake/config_models/defaults.py b/snowflake/datadog_checks/snowflake/config_models/defaults.py
@@ -76,7 +76,7 @@ def instance_only_custom_queries(field, value):
     return False
 
 
-def instance_schema(field, value):
+def instance_schema_(field, value):
     return 'ACCOUNT_USAGE'
 
 

diff --git a/snowflake/tests/test_snowflake.py b/snowflake/tests/test_snowflake.py
@@ -22,6 +22,15 @@ def test_emits_critical_service_check_when_service_is_down(dd_run_check, aggrega
     aggregator.assert_service_check('snowflake.can_connect', SnowflakeCheck.CRITICAL)
 
 
+def test_no_schema(dd_run_check, aggregator, instance):
+    config = copy.deepcopy(instance)
+    del config['schema']
+    config['login_timeout'] = 5
+    check = SnowflakeCheck(CHECK_NAME, {}, [config])
+    dd_run_check(check)
+    aggregator.assert_service_check('snowflake.can_connect', SnowflakeCheck.CRITICAL)
+
+
 def test_storage_metrics(dd_run_check, aggregator, instance):
     # type: (Callable[[SnowflakeCheck], None], AggregatorStub, Dict[str, Any]) -> None