Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hot folder with values files for baselines; render all resources #1724

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Feb 27, 2025

What this PR does / why we need it:

  • Dropping individual baseline tests in favor of hot folder where adding new baseline is matter of adding values file with a sensible name.
  • Alway render full chart since we shouldn't have any issues with dynamic fields and we can compare as strings or maps.

Change can be verified by looking at the diff between old and new baselines. New baseline should contain resource in old baseline, plus additional resources.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@levan-m levan-m changed the title Use hot folder with values file for baselines; render all resources Use hot folder with values files for baselines; render all resources Feb 27, 2025
@levan-m levan-m marked this pull request as ready for review February 27, 2025 22:51
@levan-m levan-m requested a review from a team as a code owner February 27, 2025 22:51
@levan-m levan-m requested a review from a team as a code owner February 27, 2025 22:53
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit

Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants