Handle older GKE versions #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny-jiang
commented
Feb 27, 2025
Comment on lines
+6
to
+7
| annotations: | ||
| helm.sh/hook: "pre-install,pre-upgrade" |
There was a problem hiding this comment.
Ensures that the required CRD is installed before other k8s resources
fanny-jiang
commented
Feb 27, 2025
| @@ -337,7 +337,7 @@ You are using datadog.orchestratorExplorer.enabled but you disabled the cluster | |||
| To enable it please set clusterAgent.enabled to 'true'. | |||
| {{- end }} | |||
|
|
|||
| {{- if .Values.providers.gke.autopilot}} | |||
| {{- if and (.Values.providers.gke.autopilot) (not .Values.datadog.envDict.DD_CI)}} | |||
There was a problem hiding this comment.
The .Values.datadog.envDict.DD_CI is a workaround for CI tests running in non-autopilot clusters
hmahmood
approved these changes
Feb 27, 2025
64df0bc
into
hasan.mahmood/system-probe-autopilot
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Testing done:
Non-autopilot clusters should not fail
providers.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould not failAllowlistSynchronizerproviders.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould not failAllowlistSynchronizerproviders.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould not failAllowlistSynchronizerproviders.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould not failAllowlistSynchronizerAutopilot clusters should not fail
providers.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould enable system-probe containerAllowlistSynchronizerproviders.gke.autopilot=trueshould not faildatadog.networkMonitoring.enabled=trueshould fail and throw errorAllowlistSynchronizerChecklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)