[CONTP-679] Fix bug in dca rbac generation for annotations and labels as tags: use deepcopy before merging

[adel121]

What this PR does / why we need it:

Fixes bug that causes DD_KUBERNETES_ANNOTATIONS_AS_TAGS env var to be incorrectly set to the merged value of .Values.datadog.kubernetesResourcesLabelsAsTags and .Values.datadog.kubernetesResourcesAnnotationsAsTags.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes #

Special notes for your reviewer:

The helm chart creates rbacs for the DCA based on user configuration of kubernetes resources labels and annotations as tags. This is needed so that workloadmeta can list and watch related resources to feed the tagger collector with labels and annotations so that it can generate tags.

The rbac generation is done here.

We are using mergeOverwrite directly over the values set by the user. (see here).

As a result, .Values.datadog.kubernetesResourcesAnnotationsAsTags is being modified in place (it includes a merged version with labels as tags).

Consequently, if the user does this:

kubernetesResourcesLabelsAsTags:
  pods:
    foo-1: foo-1
    
kubernetesResourcesAnnotationsAsTags:
  pods:
    foo-2: foo-2

The user gets the following env vars:

DD_KUBERNETES_RESOURCES_LABELS_AS_TAGS: '{"pods": {"foo-1": "foo-1"}}'
DD_KUBERNETES_RESOURCES_ANNOTATIONS_AS_TAGS: '{"pods":{"foo-1":"foo-1", "foo-2":"foo-2"}}'

As you can see, the second env var got a merged version of the two.

The documentation of helm says the following:

This is a deep merge operation but not a deep copy operation. Nested objects that are merged are the same instance on both dicts. If you want a deep copy along with the merge then use the deepCopy function along with merging.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Chart Version bumped
• Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
• CHANGELOG.md has been updated
• Variables are documented in the README.md
• For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

[clamoriniere]

for all this linter change. It would be good to sync with agent-onboarding team to know if we can commit in the repo the linter config so we can all use the same config.

[clamoriniere]

The change looks good. However it can be interesting to sync with agent-onboarding team to avoid having change in the baseline files if not necessary.