Add PodResources mount #1696
Merged
Add PodResources mount #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed36907 to
32a9f70
Compare
32a9f70 to
45c5f7d
Compare
celenechang
reviewed
Feb 19, 2025
| @@ -207,6 +207,8 @@ | |||
| - name: DD_OTELCOLLECTOR_ENABLED | |||
| value: "true" | |||
| {{- end }} | |||
| - name: DD_KUBERNETES_KUBELET_PODRESOURCES_SOCKET | |||
| value: {{ printf "%s/kubelet.sock" .Values.datadog.kubelet.podResourcesSocket | quote }} | |||
There was a problem hiding this comment.
overall looks good, just wondering if there's ever a chance the socket will not be called kubelet.sock ?
There was a problem hiding this comment.
From what I've seen, it seems to be hardcoded in the k8s code.
celenechang
approved these changes
Feb 19, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The median merge time in
|
celenechang
added a commit
that referenced
this pull request
Feb 19, 2025
This reverts commit 146a161.
celenechang
added a commit
that referenced
this pull request
Feb 19, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a mount to expose the PodResources kubelet API in the agent container. This will allow us to retrieve allocated resources for running pods, which is necessary for GPU monitoring (#1681).
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)