Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mergequeue): check gitlab-ci to merge PR #1620

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(mergequeue): check gitlab-ci to merge PR #1620

merged 1 commit into from
Dec 3, 2024

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Dec 3, 2024 •
edited
Loading

What this PR does / why we need it:

Since we want to run e2e tests in gitlab during the merge queue, the parameter gitlab_check_enable must be true.

Which issue this PR fixes

Mergequeue should check the gitlab pipeline status before merging

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@clamoriniere clamoriniere requested a review from a team as a code owner December 3, 2024 08:53
@clamoriniere clamoriniere merged commit 1ccd7aa into main Dec 3, 2024
3 checks passed
@clamoriniere clamoriniere deleted the clamoriniere/merge-queue branch December 3, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbavelier tbavelier tbavelier approved these changes

Assignees
No one assigned
Labels
tooling tools/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clamoriniere @tbavelier