Enable datadog chart EKS E2E tests in CI #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny-jiang
commented
Feb 15, 2024
| @@ -1,7 +1,3 @@ | |||
| variables: | |||
| # Do not modify this - must be the repository name for Kubernetes gitlab runners to run | |||
| KUBERNETES_SERVICE_ACCOUNT_OVERWRITE: helm-charts | |||
There was a problem hiding this comment.
fanny-jiang
commented
Feb 15, 2024
Comment on lines
-20
to
-26
| # Update awscli v2 | ||
| - aws --version | ||
| - curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip" | ||
| - unzip awscliv2.zip | ||
| - ./aws/install --update | ||
| - aws --version | ||
| # Setup AWS Credentials |
There was a problem hiding this comment.
Updated test-infra-definitions runner image uses newer awscli v2, so we don't need to update the version in the job
fanny-jiang
commented
Feb 16, 2024
| } | ||
| } else { | ||
| err = fmt.Errorf("could not create Kubernetes client, cluster kubeconfig is nil") | ||
| } | ||
| } | ||
| if err != nil { | ||
| t.Skipf("Skipping test. Encountered problem creating or updating E2E stack: %s", err) | ||
| t.Errorf("Skipping tests. Encountered problem creating or updating E2E stack: %s", err) |
There was a problem hiding this comment.
Make the job fail if there's an issue creating the E2E environment.
levan-m
approved these changes
Feb 16, 2024
levan-m
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable Datadog E2E in EKS tests in CI. E2E tests run when a branch is merged to
main(ignores docs changes). E2E tests can be run manually if a commit is made to a non-mainbranch.test-infra-definitionsrunner imageTest run: https://gitlab.ddbuild.io/DataDog/helm-charts/-/jobs/436459182
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)