Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to allow agent role to curl /metrics/slis #1155

Merged

Conversation

jennchenn
Copy link
Member

What this PR does / why we need it:

A rule was added to allow the agent to curl /metrics/slis, exposing the SLI metrics provided by Kubernetes as a part of the changes made in DataDog/integrations-core#15731

Special notes for your reviewer:

Does the corresponding change need to be made in the operator as well?

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@jennchenn jennchenn changed the title Jenn/cont 4201 add support for kube scheduler sli metrics Add rule to allow agent role to curl /metrics/slis Aug 31, 2023
@jennchenn jennchenn marked this pull request as ready for review August 31, 2023 16:17
@jennchenn jennchenn requested a review from a team as a code owner August 31, 2023 16:17
Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the corresponding change need to be made in the operator as well?

Indeed, this change will have to be ported to the datadog-operator.
Here is where the datadog-operator is defining the agent cluster role:

But, in order for the operator to be able to grant some permissions, it needs to have them for itself. Those are defined in:

@jennchenn jennchenn force-pushed the jenn/CONT-4201-add-support-for-kube-scheduler-sli-metrics branch from 9846f69 to 116999e Compare September 5, 2023 19:10
@jennchenn jennchenn merged commit de6686c into main Sep 7, 2023
@jennchenn jennchenn deleted the jenn/CONT-4201-add-support-for-kube-scheduler-sli-metrics branch September 7, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants