Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-7627] Add OTel Kafka Metrics Docs #21505

Merged
merged 16 commits into from
Apr 10, 2024
Merged

[DOCS-7627] Add OTel Kafka Metrics Docs #21505

merged 16 commits into from
Apr 10, 2024

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Jan 24, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Add OTel Kafka Metrics Docs.

Merge instructions

Additional notes

@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@mackjmr mackjmr requested a review from dineshg13 March 20, 2024 14:36
@mackjmr mackjmr marked this pull request as ready for review March 22, 2024 13:24
@mackjmr mackjmr requested a review from a team as a code owner March 22, 2024 13:24
@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 25, 2024
@buraizu
Copy link
Contributor

buraizu commented Mar 25, 2024

Added the Work in Progress label for now to remove from the documentation team's review queue, as there is feedback that needs to be resolved before we can properly review. Please remove the label once it's ready for review, or feel free to reach out on the documentation channel.

@mackjmr mackjmr removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 8, 2024
@mackjmr
Copy link
Member Author

mackjmr commented Apr 8, 2024

@buraizu this should be ready for review now, removed the work in progress label 👍

@buraizu buraizu added the editorial review Waiting on a more in-depth review label Apr 8, 2024
@buraizu
Copy link
Contributor

buraizu commented Apr 8, 2024

Thanks, created DOCS-7627 to review

@buraizu buraizu changed the title Add OTel Kafka Metrics Docs [DOCS-7627] Add OTel Kafka Metrics Docs Apr 8, 2024
brett0000FF
brett0000FF reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for writing this up. I left several suggestions to align with our style guide. Please let me know once you've addressed these, and I can approve/merge this. 👍

config/_default/menus/menus.en.yaml Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
content/en/opentelemetry/integrations/kafka_metrics.md Outdated Show resolved Hide resolved
mackjmr and others added 9 commits April 10, 2024 13:41
@mackjmr @brett0000FF
Update config/_default/menus/menus.en.yaml
6898e60 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
4b7cac3 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
17576f6 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
cdff94a 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
a9c81f2 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/schema_semantics/metrics_mapping.md
bc2bef2 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/schema_semantics/metrics_mapping.md
905b6dc 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
b925872 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
c4b045d 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
mackjmr and others added 2 commits April 10, 2024 13:43
@mackjmr @brett0000FF
Update content/en/opentelemetry/integrations/kafka_metrics.md
55f5efd 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr @brett0000FF
Apply suggestions from code review
2ab6e22 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@mackjmr
Copy link
Member Author

mackjmr commented Apr 10, 2024

Thanks @brett0000FF, applied all suggestions 👍

brett0000FF
brett0000FF approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mackjmr Great, thanks! Are you ready for me to merge this? It looks good to me now.

@mackjmr
Copy link
Member Author

mackjmr commented Apr 10, 2024

@brett0000FF yes we are good to merge 👍

@brett0000FF brett0000FF merged commit 94fb5a4 into master Apr 10, 2024
13 checks passed
@brett0000FF brett0000FF deleted the mackjmr/otel-kafka-docs branch April 10, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

@dineshg13 dineshg13 dineshg13 approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mackjmr @buraizu @dineshg13 @brett0000FF