Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated tracer health metrics #859

Merged
merged 25 commits into from
Nov 20, 2019
Merged

Conversation

delner
Copy link
Contributor

@delner delner commented Nov 19, 2019

To monitor the health and performance of the tracer, this pull request adds health metrics to the tracer and other core components, which are sent as Statsd metrics under the datadog.tracer.* prefix. These metrics can then be graphed to evaluate the health, stability and impact of the trace library within a Ruby application.

By default, these metrics are enabled, if dogstatsd-ruby >= 3.3.0 is available. They can be disabled by setting the DD_DEBUG_HEALTH_METRICS_ENABLED ENV var to 0.

List of metrics added with this pull request:

datadog.tracer.api.errors
datadog.tracer.api.requests
datadog.tracer.api.responses
datadog.tracer.queue.accepted
datadog.tracer.queue.accepted_lengths
datadog.tracer.queue.dropped
datadog.tracer.queue.length
datadog.tracer.queue.max_length
datadog.tracer.queue.spans
datadog.tracer.traces.filtered # Added but not implemented
datadog.tracer.writer.cpu_time # Added but not implemented

This pull request is based upon #838 and changes its implementation to aggregate queue metrics and reduce the number of Statsd events sent.

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Nov 19, 2019
@delner delner added this to the 0.29.0 milestone Nov 19, 2019
@delner delner requested review from brettlangdon and a team November 19, 2019 17:14
@delner delner self-assigned this Nov 19, 2019
@delner delner changed the title Aggregated queue metrics Aggregated tracer health metrics Nov 19, 2019
@delner delner force-pushed the refactor/aggregated_queue_metrics branch from 3f9ce28 to 06dfed2 Compare November 20, 2019 17:55
@delner delner merged commit 132c019 into master Nov 20, 2019
@delner delner deleted the refactor/aggregated_queue_metrics branch November 20, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants