Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move buffer size and flush interval defaults into constants #851

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Move buffer size and flush interval defaults into constants #851

merged 2 commits into from
Nov 1, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Oct 31, 2019

This pull request moves some default values into constants, and makes the writer configurable from Datadog.tracer.configure (in order to change buffer size.)

@delner delner added the core Involves Datadog core libraries label Oct 31, 2019
@delner delner added this to the 0.29.0 milestone Oct 31, 2019
@delner delner requested review from marcotc and a team October 31, 2019 22:10
@delner delner self-assigned this Oct 31, 2019
@delner delner force-pushed the refactor/buffer_size_options branch from 6531be1 to 7dc6a8d Compare October 31, 2019 22:17
@delner delner force-pushed the refactor/buffer_size_options branch from 7dc6a8d to 9d37e7e Compare October 31, 2019 22:40
@delner delner merged commit ad2ac06 into master Nov 1, 2019
@delner delner deleted the refactor/buffer_size_options branch November 1, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @marcotc @brettlangdon