Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Adjust leaking thread detection for new Rails #4481

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 12, 2025

What does this PR do?

This will fix the warning about the leaking threads in the tests for ActiveRecord connection reaper.

Motivation:

Result of the discussion with guild regarding that issue. It turns out we already was ignoring the reaper, but only for the older versions of ActiveRecord.

Change log entry

No. Internal change

Additional Notes:

None.

How to test the change?

CI

@Strech Strech requested a review from a team as a code owner March 12, 2025 08:02
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Mar 12, 2025
@Strech Strech added the dev/internal Other internal work that does not need to be included in the changelog label Mar 12, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: fix-leaking-thread-detection-for-connection-reaper
Commit report: f851bc4
Test service: dd-trace-rb

✅ 0 Failed, 20629 Passed, 1370 Skipped, 3m 18.34s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2025

Benchmarks

Benchmark execution time: 2025-03-12 08:30:01

Comparing candidate commit f851bc4 in PR branch fix-leaking-thread-detection-for-connection-reaper with baseline commit 65b2901 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (65b2901) to head (f851bc4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4481      +/-   ##
==========================================
- Coverage   97.70%   97.68%   -0.02%     
==========================================
  Files        1379     1379              
  Lines       83881    83880       -1     
  Branches     4251     4251              
==========================================
- Hits        81953    81938      -15     
- Misses       1928     1942      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strech Strech enabled auto-merge March 12, 2025 09:59
@Strech Strech merged commit 8dac6a4 into master Mar 12, 2025
276 checks passed
@Strech Strech deleted the fix-leaking-thread-detection-for-connection-reaper branch March 12, 2025 10:05
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants