Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport wip #4480

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Transport wip #4480

wants to merge 28 commits into from

Conversation

p-datadog
Copy link
Member

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries tracing labels Mar 11, 2025
Copy link

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-03-11 21:45:03 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: transport-dry-3
Commit report: 71618a4
Test service: dd-trace-rb

✅ 0 Failed, 20630 Passed, 1459 Skipped, 3m 18.28s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-12 14:36:25

Comparing candidate commit 71618a4 in PR branch transport-dry-3 with baseline commit 65b2901 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

p added 5 commits March 12, 2025 08:00
* transport-dry-4:
  types
  types
  DRY endpoint not supported exception
  DRY missing endpoint exception
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 98.37398% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.73%. Comparing base (65b2901) to head (71618a4).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/core/remote/transport/http/config.rb 66.66% 1 Missing ⚠️
.../datadog/core/remote/transport/http/negotiation.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4480      +/-   ##
==========================================
+ Coverage   97.70%   97.73%   +0.03%     
==========================================
  Files        1379     1382       +3     
  Lines       83881    83827      -54     
  Branches     4251     4231      -20     
==========================================
- Hits        81953    81929      -24     
+ Misses       1928     1898      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants