Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dd scan #4476

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Remove dd scan #4476

merged 3 commits into from
Mar 12, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

We are not really using those scans as they are not blocking

Change log entry

None.

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 11, 2025
@TonyCTHsu TonyCTHsu marked this pull request as ready for review March 11, 2025 11:34
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner March 11, 2025 11:34
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (65b2901) to head (6fdfe02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4476      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1379     1379              
  Lines       83881    83881              
  Branches     4251     4251              
==========================================
- Hits        81953    81945       -8     
- Misses       1928     1936       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: tonycthsu/remove-dd-scan
Commit report: 6fdfe02
Test service: dd-trace-rb

✅ 0 Failed, 20626 Passed, 1373 Skipped, 3m 10.94s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-12 09:13:30

Comparing candidate commit 6fdfe02 in PR branch tonycthsu/remove-dd-scan with baseline commit 65b2901 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@ivoanjo
Copy link
Member

ivoanjo commented Mar 11, 2025

Thoughts @anmarchenko? Since you were the one that added this in #3755

@ivoanjo ivoanjo requested a review from anmarchenko March 11, 2025 12:13
@anmarchenko
Copy link
Member

Let's just remove this @ivoanjo, I have no evidence that additional static analysis from DD adds anything useful to the project

@TonyCTHsu TonyCTHsu enabled auto-merge March 12, 2025 08:57
@TonyCTHsu TonyCTHsu merged commit c788106 into master Mar 12, 2025
480 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-dd-scan branch March 12, 2025 09:15
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants