Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-56960] Add collection of request headers for identity #4468

Merged

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 6, 2025

What does this PR do?
Two things:

  1. Add new event for Rack contrib named rack.request.finish
  2. Add subscriber to the said event to set tags of identity related headers (see User event)

Motivation:

This will be a part of the #4433 and could be extracted without a fear of breaking anything.

Change log entry

No. It will be announced as of #4433 release

Additional Notes:

Unfortunately, we don't have time to go over the current published/subscriber model and it has very odd limitations. Hence the code is placed in the most convenient way, but not in the most right.

How to test the change?

CI is good enough.

@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Mar 6, 2025
@Strech Strech changed the title Add collection of request headers for identity [APPSEC-56960] Add collection of request headers for identity Mar 6, 2025
@Strech Strech marked this pull request as ready for review March 6, 2025 16:17
@Strech Strech requested a review from a team as a code owner March 6, 2025 16:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (f7b904d) to head (f5cff78).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4468      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1376     1378       +2     
  Lines       83824    83898      +74     
  Branches     4251     4253       +2     
==========================================
+ Hits        81897    81967      +70     
- Misses       1927     1931       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 6, 2025

Datadog Report

Branch report: appsec-56960-add-collection-of-rack-request-headers-to-identity
Commit report: f5cff78
Test service: dd-trace-rb

✅ 0 Failed, 20432 Passed, 1369 Skipped, 3m 15.16s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 6, 2025

Benchmarks

Benchmark execution time: 2025-03-08 11:25:38

Comparing candidate commit f5cff78 in PR branch appsec-56960-add-collection-of-rack-request-headers-to-identity with baseline commit f7b904d in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+3361.952op/s; +3434.687op/s] or [+11.475%; +11.724%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+8194.009op/s; +8517.301op/s] or [+7.498%; +7.794%]

@Strech Strech merged commit d2a9bda into master Mar 12, 2025
482 checks passed
@Strech Strech deleted the appsec-56960-add-collection-of-rack-request-headers-to-identity branch March 12, 2025 09:59
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants