Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan with actionlint #4457

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Scan with actionlint #4457

merged 1 commit into from
Mar 5, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

  • Add actionlint job
  • Fix issues

Change log entry
None.

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 5, 2025
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 5, 2025
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/actionlint branch from e699fa9 to 712af4b Compare March 5, 2025 11:30
@TonyCTHsu TonyCTHsu changed the base branch from master to tonycthsu/zizmore March 5, 2025 11:30
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: tonycthsu/actionlint
Commit report: 77d83ef
Test service: dd-trace-rb

✅ 0 Failed, 20624 Passed, 1371 Skipped, 3m 10.23s Total Time

@TonyCTHsu TonyCTHsu changed the base branch from tonycthsu/zizmore to master March 5, 2025 11:48
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/actionlint branch from 0323d72 to 25ec963 Compare March 5, 2025 11:50
@TonyCTHsu TonyCTHsu added the do-not-merge/WIP Not ready for merge label Mar 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 5, 2025

Benchmarks

Benchmark execution time: 2025-03-05 13:01:39

Comparing candidate commit 77d83ef in PR branch tonycthsu/actionlint with baseline commit 1e9d70f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (34bf118) to head (77d83ef).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4457      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files        1375     1375              
  Lines       83813    83812       -1     
  Branches     4251     4251              
==========================================
- Hits        81885    81879       -6     
- Misses       1928     1933       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/actionlint branch from 63dd3aa to 77d83ef Compare March 5, 2025 12:37
@TonyCTHsu TonyCTHsu marked this pull request as ready for review March 5, 2025 13:03
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner March 5, 2025 13:03
@TonyCTHsu TonyCTHsu changed the title Use actionlint Scan with actionlint Mar 5, 2025
@TonyCTHsu TonyCTHsu removed the do-not-merge/WIP Not ready for merge label Mar 5, 2025
@TonyCTHsu TonyCTHsu merged commit 2f427f8 into master Mar 5, 2025
482 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/actionlint branch March 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants