Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan with zizmor #4456

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Scan with zizmor #4456

merged 3 commits into from
Mar 5, 2025

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Use zizmor to lint our Github Actions.

  • Add a job for zizmor
  • Set zizmor with minimum severity with low
  • Fix most issues.

Change log entry
None.

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Mar 5, 2025
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Mar 5, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 5, 2025

Datadog Report

Branch report: tonycthsu/zizmore
Commit report: ca054d3
Test service: dd-trace-rb

✅ 0 Failed, 20623 Passed, 1370 Skipped, 3m 18.19s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (34bf118) to head (ca054d3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4456      +/-   ##
==========================================
- Coverage   97.69%   97.69%   -0.01%     
==========================================
  Files        1375     1375              
  Lines       83813    83812       -1     
  Branches     4251     4251              
==========================================
- Hits        81884    81880       -4     
- Misses       1929     1932       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Mar 5, 2025

Benchmarks

Benchmark execution time: 2025-03-05 11:51:13

Comparing candidate commit ca054d3 in PR branch tonycthsu/zizmore with baseline commit 34bf118 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - gvl benchmark samples

  • 🟩 throughput [+884.658op/s; +892.463op/s] or [+8.307%; +8.380%]

@TonyCTHsu TonyCTHsu marked this pull request as ready for review March 5, 2025 10:28
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner March 5, 2025 10:28
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/zizmore branch from 7d04789 to 7e366f2 Compare March 5, 2025 11:19
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/zizmore branch from 7e366f2 to ca054d3 Compare March 5, 2025 11:27
@TonyCTHsu TonyCTHsu changed the title Use zizmor Scan with zizmor Mar 5, 2025
@TonyCTHsu TonyCTHsu merged commit 1e9d70f into master Mar 5, 2025
491 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/zizmore branch March 5, 2025 12:33
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants