-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop for ruby 2.7+ #4448
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4448 +/- ##
==========================================
- Coverage 97.69% 97.68% -0.02%
==========================================
Files 1381 1381
Lines 83955 83954 -1
Branches 4253 4249 -4
==========================================
- Hits 82024 82011 -13
- Misses 1931 1943 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20631 Passed, 1371 Skipped, 3m 26.05s Total Time |
b462716
to
d37fb33
Compare
d37fb33
to
8f11f8f
Compare
What does this PR do?
Updates rubocop and related dependencies to newer versions.
Removes rubocop from ruby 2.6 configuration since the current versions of rubocop do not support ruby 2.6.
Removes rubocop from jruby 9.3 configuration because jruby 9.3 identifies as ruby 2.6 and hence rubocop does not support it anymore.
Removes standard from rubies that do not have rubocop, because then it would bring an old rubocop that wouldn't behave the same as the one in supported versions.
Updates rubocop to 1.71. Current version of rubocop is 1.73 but standard does not support 1.73 yet.
standard version is not explicitly specified but it gets updated to 1.45 from somewhere in the 1.20 range.
Several files edited for changes demanded by recent rubocops.
rubocop-rspec updated to most recent 2.x release, 3.0 has many new demands producing a huge diff likely to conflict with other PRs.
Motivation:
Noticed old version when testing rubocop/rubocop#13933
Change log entry
None
Additional Notes:
Since rubocop, standard and related libraries need to have synchronized versions, this PR does not update rubocop to its latest version (currently 1.73, PR updates to 1.71) and e.g. rubocop-performance needs to be declared as 1.20 not 1.23.
rubocop-rspec 3.x wants to make MANY changes to our test suite, they will probably conflict with in-progress PRs.
How to test the change?
Existing CI