Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppSec server-side request forgery remote capability #4446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

y9v
Copy link
Member

@y9v y9v commented Feb 28, 2025

What does this PR do?
This PR adds a remote capability for AppSec server-side request forgery exploit prevention.

Motivation:
We have instrumentation for Faraday, Excon, and RestClient to detect SSRF attacks.

Change log entry
None. This is internal change.

Additional Notes:
Don't merge before #4269

How to test the change?
CI is enough.

@y9v y9v self-assigned this Feb 28, 2025
@y9v y9v requested a review from a team as a code owner February 28, 2025 17:04
@github-actions github-actions bot added the appsec Application Security monitoring product label Feb 28, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (987b7a6) to head (602314a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4446      +/-   ##
==========================================
- Coverage   97.70%   97.68%   -0.03%     
==========================================
  Files        1374     1374              
  Lines       83807    83807              
  Branches     4249     4249              
==========================================
- Hits        81881    81863      -18     
- Misses       1926     1944      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: appsec-add-rasp-ssrf-remote-capability
Commit report: 602314a
Test service: dd-trace-rb

✅ 0 Failed, 20611 Passed, 1371 Skipped, 3m 16.06s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025

Benchmarks

Benchmark execution time: 2025-02-28 17:27:21

Comparing candidate commit 602314a in PR branch appsec-add-rasp-ssrf-remote-capability with baseline commit 987b7a6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #4445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants