Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish action #4430

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix publish action #4430

merged 2 commits into from
Feb 26, 2025

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Feb 24, 2025

What does this PR do?

https://github.com/DataDog/dd-trace-rb/actions/runs/13496397564

Fix error from releasing 2.11.0

  1. Fix github-release job with the repo information
  2. Fix update-gem-version job with ruby installed
  3. Fix update-release-branch job with the correct url and branch

Change log entry
None

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Feb 24, 2025
@github-actions github-actions bot added the dev/github Github repository maintenance and automation label Feb 24, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 24, 2025

Benchmarks

Benchmark execution time: 2025-02-26 11:06:21

Comparing candidate commit d7f2928 in PR branch tonycthsu/fix-publish with baseline commit b2274aa in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟥 throughput [-9447.891op/s; -8939.263op/s] or [-5.663%; -5.358%]

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (b2274aa) to head (d7f2928).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4430      +/-   ##
==========================================
- Coverage   97.71%   97.69%   -0.02%     
==========================================
  Files        1374     1374              
  Lines       83716    83715       -1     
  Branches     4236     4236              
==========================================
- Hits        81805    81789      -16     
- Misses       1911     1926      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 24, 2025

Datadog Report

Branch report: tonycthsu/fix-publish
Commit report: d7f2928
Test service: dd-trace-rb

✅ 0 Failed, 20609 Passed, 1371 Skipped, 3m 15.6s Total Time

@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/fix-publish branch from affac89 to d7f2928 Compare February 26, 2025 10:42
@TonyCTHsu TonyCTHsu marked this pull request as ready for review February 26, 2025 10:47
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner February 26, 2025 10:47
@TonyCTHsu TonyCTHsu added this to the 2.12.0 milestone Feb 26, 2025
@TonyCTHsu TonyCTHsu merged commit 25911c5 into master Feb 26, 2025
500 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-publish branch February 26, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/github Github repository maintenance and automation dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants