Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(propagation): baggage support and automatic propagation #4371

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Feb 11, 2025

What does this PR do?
Following the spec here: https://www.w3.org/TR/baggage/ we implement baggage for the Ruby tracer. The otel drop in support will be added in a future PR.
Motivation:

Change log entry

Additional Notes:

How to test the change?

Copy link

github-actions bot commented Feb 11, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-02-20 19:01:38 UTC

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from e9d741c to eee20a9 Compare February 11, 2025 22:55
@github-actions github-actions bot added the integrations Involves tracing integrations label Feb 11, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: zachg/baggage_support
Commit report: 53087f8
Test service: dd-trace-rb

✅ 0 Failed, 20684 Passed, 1371 Skipped, 3m 7.51s Total Time

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from eee20a9 to 751ca10 Compare February 12, 2025 19:47
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2025

Benchmarks

Benchmark execution time: 2025-03-12 19:13:38

Comparing candidate commit ec0d718 in PR branch zachg/baggage_support with baseline commit f710dac in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from 7919272 to 64cb8a6 Compare February 19, 2025 18:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.57627% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.75%. Comparing base (20886bc) to head (4dbe74b).
Report is 177 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/tracing/distributed/baggage.rb 98.59% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4371      +/-   ##
==========================================
+ Coverage   97.74%   97.75%   +0.01%     
==========================================
  Files        1351     1353       +2     
  Lines       82697    82908     +211     
  Branches     4198     4222      +24     
==========================================
+ Hits        80831    81047     +216     
+ Misses       1866     1861       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZStriker19 ZStriker19 changed the title feat(propagation): otel baggage support feat(propagation): baggage support and automatic propagation Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants