-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL: Capture user-provided error extension values #4325
Conversation
Thank you for updating Change log entry section 👏 Visited at: 2025-01-31 22:26:52 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20131 Passed, 1361 Skipped, 3m 12.89s Total Time |
2e6fa76
to
0c4de1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4325 +/- ##
==========================================
- Coverage 97.71% 97.70% -0.01%
==========================================
Files 1353 1355 +2
Lines 82975 83051 +76
Branches 4213 4218 +5
==========================================
+ Hits 81078 81144 +66
- Misses 1897 1907 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a minor update requested
Co-authored-by: Ivo Anjo <ivo.anjo@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor suggestion to avoid undefined method on NilClass
lib/datadog/tracing/contrib/graphql/configuration/error_extension_env_parser.rb
Outdated
Show resolved
Hide resolved
b735813
to
8b58748
Compare
A follow up from #4177, this PR allows users to capture custom error fields (called
extensions
in GraphQL).Here's an example of an error with
extensions
(link):extensions
can contain any arbitrary data, but are often important for error debugging.Because
extensions
can contain PII, or pretty much any arbitrary user-provided information, theextensions
that are allowed to be capture bydd-trace-rb
have to be added to a list in theDD_TRACE_GRAPHQL_ERROR_EXTENSIONS
configuration.Change log entry
No. This will be covered by #4177.
How to test the change?
All changes have automated tests.